Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlterProperty delta fails if altering a property with a Linked Class #232

Closed
mmacfadden opened this issue Jun 26, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working server Issues related to the server
Milestone

Comments

@mmacfadden
Copy link
Contributor

Versions

  • Convergence Version: 1.0.0-rc.9

Describe the Bug
When using an alter property, the structure is not smart enough to tell if you are unsetting the linked class, or if you are simply choosing not to alter it. This can result in a null pointer exception in OrientDB in the DeltaProcessor.

https://github.com/convergencelabs/convergence-server/blob/66d3f7ec46bfa4cdd1b266802da1e32601a57ea1/src/main/scala/com/convergencelabs/convergence/server/backend/db/schema/DeltaProcessor.scala#L139

At this time we don't have any deltas that expose this bug, or that alter the linked class. We need to change the structure of this delta object tin a backwards compatible way.

@mmacfadden mmacfadden added bug Something isn't working server Issues related to the server labels Jun 26, 2021
@mmacfadden mmacfadden added this to the 1.0.0-rc.11 milestone Jun 26, 2021
@mmacfadden mmacfadden self-assigned this Jun 26, 2021
@mmacfadden mmacfadden modified the milestones: 1.0.0-rc.12, 1.0.0-rc.10 Jul 12, 2021
@mmacfadden
Copy link
Contributor Author

Created a fix to work around this OrientDB bug:

orientechnologies/orientdb#9639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server Issues related to the server
Projects
None yet
Development

No branches or pull requests

1 participant