Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to playback StringSpliceOperations #253

Closed
mmacfadden opened this issue Jul 22, 2021 · 1 comment
Closed

Unable to playback StringSpliceOperations #253

mmacfadden opened this issue Jul 22, 2021 · 1 comment
Assignees
Labels
bug Something isn't working client Issues related to the client
Milestone

Comments

@mmacfadden
Copy link
Contributor

mmacfadden commented Jul 22, 2021

Versions

  • Convergence Version: 1.0.0-rc.11

Describe the Bug
The AppliedStringOperation uses the wrong string constant, which prevents historical playback of models with String Splice operations. When attempting to play back string operations in the historical model the client will produce an error:

convergence.esm.js:10420 Uncaught (in promise) Error: Invalid operation!
    at StringNode._handleModelOperationEvent (convergence.esm.js:10420)
    at Model.handleModelOperationEvent (convergence.esm.js:11236)
    at HistoricalModel._playDiscreteOp (convergence.esm.js:14867)
    at convergence.esm.js:14844
    at Array.forEach (<anonymous>)
    at HistoricalModel._playOperations (convergence.esm.js:14835)
    at HistoricalModel._checkAndProcess (convergence.esm.js:14828)
    at convergence.esm.js:14785

The AppliedStringSpliceOperation constructor needs to be updated to pass the correct string constant to it's constructor.

https://github.com/convergencelabs/convergence-client-javascript/blob/4b8e9abac83049d26f68b76a8eb89d0c42511586/src/main/model/ot/applied/AppliedStringSpliceOperation.ts#L31

@mmacfadden mmacfadden added bug Something isn't working client Issues related to the client labels Jul 22, 2021
@mmacfadden mmacfadden added this to the 1.0.0-rc.12 milestone Jul 22, 2021
@mmacfadden mmacfadden self-assigned this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues related to the client
Projects
None yet
Development

No branches or pull requests

1 participant