Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open models remain available if not closed when page unloads #60

Closed
mmacfadden opened this issue Jan 10, 2020 · 0 comments
Closed

Open models remain available if not closed when page unloads #60

mmacfadden opened this issue Jan 10, 2020 · 0 comments
Assignees
Labels
bug Something isn't working client Issues related to the client
Milestone

Comments

@mmacfadden
Copy link
Contributor

Versions
Please fill in all that apply:

  • Convergence Version: 1.0.0-rc.4

Describe the Bug
Open models are always available locally. If you have model open and then uncleanly unload the page without closing models or disposing the domain. The logic that removes the local model does not get triggered. When you reload the page, the model is listed as available.

Step To Reproduce
A code snippet or gist to reproduce the issue will greatly improve our response time

  1. connect online.
  2. open a model.
  3. Refresh the page.
  4. Connect online.

Expected Behavior
The model should not be there anymore. It seems like upon initialization we should purge models like this.

@mmacfadden mmacfadden added the bug Something isn't working label Jan 10, 2020
@mmacfadden mmacfadden added this to the 1.0.0-rc.5 milestone Jan 10, 2020
@mmacfadden mmacfadden self-assigned this Jan 10, 2020
@mmacfadden mmacfadden added the client Issues related to the client label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues related to the client
Projects
None yet
Development

No branches or pull requests

1 participant