A user can now add himself as a contact #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaosKid42
force-pushed
the
self_contact
branch
2 times, most recently
from
b89e430
to
cec4dac
Compare
jcbrand
reviewed
Jan 9, 2020
src/headless/converse-roster.js
Outdated
|
|
||
| const contact = this.get(jid); | ||
| const subscription = item.getAttribute("subscription"); | ||
| const subscription = this.isSelf(jid) ? 'both' : item.getAttribute("subscription"); |
There was a problem hiding this comment.
This feels too hacky. What happens when you just remove line 658, without making this change?
There was a problem hiding this comment.
Because of subscription === null the roster item won't be shown.
I updated the PR to make it less hacky: Now the case of a roster item belonging to yourself is handled in rosterview.
ChaosKid42
force-pushed
the
self_contact
branch
4 times, most recently
from
89b29fd
to
f91b38a
Compare
|
@ChaosKid42 Please resolve the conflicts, then I'll merge. |
ChaosKid42
force-pushed
the
self_contact
branch
from
f91b38a
to
bebe316
Compare
|
@jcbrand Resolved the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very much simplified version of #1634.
It does not do anything about the subscription of the self contact and also does not show the correct user status (online/away etc). It is however sufficient to safe your own contact to the roster and use it for whatever you want to do with it (might e.g. be useful to send data such as images from your computer to your smartphone).
The subscription of the self contact is always shown as "both" regardless of what is actually saved in the roster. This is of course not entirely correct but might nevertheless be acceptable taking into account that this solution only needs minimum changes to the code.