fix emojis in case use_system_emojis == false #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaosKid42
force-pushed
the
fix_emojis_if_not_system_emojis
branch
from
c40b09f
to
7ef31b0
Compare
|
Thanks @ChaosKid42, looks good. Could you please add a regressoin test to Similar to this one: Line 259 in 0594c48 |
ChaosKid42
force-pushed
the
fix_emojis_if_not_system_emojis
branch
from
7ef31b0
to
c044b51
Compare
@jcbrand : Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that emojis weren't rendered in case
use_system_emojis == false. This PR fixes it.