Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate links (show_images_inline: false) #2281

Open
licaon-kter opened this issue Oct 9, 2020 · 0 comments
Open

Don't duplicate links (show_images_inline: false) #2281

licaon-kter opened this issue Oct 9, 2020 · 0 comments

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Oct 9, 2020

Background: The clients I know (converse.js, Conversations) send the Image URL as plaintext and as OOB-data. Usually, they should point at the same destination. But they may not. Therefore the plaintext is rendered as an image and OOB-data is rendered as a link. btw: for other media (audio, video) that's the same, i.e. they are also rendered as media and link.

@

So do that if you can preview the link/file but if you can't show the preview because of the settings (show_images_inline: false) or because the file is not media (eg. upload an APK/ODS/etc) then there should not be 2 links on screen.

Even for media, ok for security show them if they differ, if not then show the media and users can just right-click download/etc


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Echolon Echolon changed the title Don't duplicate links Don't duplicate links (show_images_inline: false) Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants