-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - Create blood glucose (mmo/l - mg/dL) & hba1c (mmol-mol) - (percent) #83
Comments
If you would like to add these units, feel free to submit a pull request following the design patterns of the library. Pull Request #51 might also allow the library to add units on the fly for custom units not currently built into the library. If not, I will see when these units can be added. Digging through current issues and pull requests to see what is the easiest to add / fix first. |
@jiminikiz I've already did this conversion, if you can advice me to which unit group should this conversion goes I can create a PR right away |
We may need a new definition, concentration to handle all mass per unit volume scenarios. Perhaps density measures should also go into the same file. Seems like different variants of
Ref: Perry The range of units is large and there can be valid reasons to not support all of them. But should we start by just supporting metric/SI units as concentration is quite a useful unit of measure? @Taar Does it look like a good v3 candidate? I can help with the PR if needed. |
Any update on this one? How can I support density units ( |
@cchamikara can you please share the code block how you did it? |
I also need this, please share :) |
Just a another set of units you could add 馃憤
The text was updated successfully, but these errors were encountered: