fix(gtfsplus): fix react warnings (key, proptypes)

ibi-group · Mar 14, 2017 · 8d5eb28 · 8d5eb28
1 parent 23c4f00
commit 8d5eb28
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 10 deletions.
diff --git a/lib/gtfs/components/gtfssearch.js b/lib/gtfs/components/gtfssearch.js
@@ -7,7 +7,7 @@ import { getFeed, getFeedId } from '../../common/util/modules'
 
 export default class GtfsSearch extends Component {
   static propTypes = {
-    value: PropTypes.string
+    value: PropTypes.object
   }
   constructor (props) {
     super(props)

diff --git a/lib/gtfsplus/components/GtfsPlusEditor.js b/lib/gtfsplus/components/GtfsPlusEditor.js
@@ -9,7 +9,7 @@ import { getConfigProperty } from '../../common/util/config'
 
 export default class GtfsPlusEditor extends Component {
   static propTypes = {
-    onComponentMount: PropTypes.function
+    onComponentMount: PropTypes.func
   }
   constructor (props) {
     super(props)
@@ -111,8 +111,8 @@ export default class GtfsPlusEditor extends Component {
 
           <Row>
             <Col xs={2}>
-              {getConfigProperty('modules.gtfsplus.spec').map(table => {
-                return (<p>
+              {getConfigProperty('modules.gtfsplus.spec').map((table, index) => {
+                return (<p key={index}>
                   <Button
                     bsStyle={table.id === this.state.activeTableId ? 'info' : 'default'}
                     key={table.id}

diff --git a/lib/gtfsplus/components/GtfsPlusTable.js b/lib/gtfsplus/components/GtfsPlusTable.js
@@ -90,7 +90,7 @@ export default class GtfsPlusTable extends Component {
                 ? `${routeEntity.route_short_name} - ${routeEntity.route_long_name}`
                 : routeEntity.route_long_name
             }
-            : ''
+            : null
 
           return (
             <GtfsSearch
@@ -110,7 +110,7 @@ export default class GtfsPlusTable extends Component {
           const stopEntity = this.props.getGtfsEntity('stop', currentValue)
           const stopValue = stopEntity
             ? {'value': stopEntity.stop_id, 'label': stopEntity.stop_name}
-            : ''
+            : null
 
           return (
             <GtfsSearch
@@ -235,8 +235,8 @@ export default class GtfsPlusTable extends Component {
       <Table>
         <thead>
           <tr>
-            {table.fields.map(field => {
-              return (<th style={colHeaderStyle} className={`col-md-${field.columnWidth}`}>
+            {table.fields.map((field, index) => {
+              return (<th style={colHeaderStyle} key={index} className={`col-md-${field.columnWidth}`}>
                 {field.name}{field.required ? ' *' : ''}
                 <Glyphicon
                   glyph='question-sign'

diff --git a/lib/manager/components/FeedSourceViewer.js b/lib/manager/components/FeedSourceViewer.js
@@ -175,7 +175,7 @@ export default class FeedSourceViewer extends Component {
                 <ControlLabel>Feed source fetch URL</ControlLabel>
                 <InputGroup>
                   <FormControl
-                    value={typeof this.state.url !== 'undefined' ? this.state.url : fs.url}
+                    value={typeof this.state.url !== 'undefined' ? this.state.url : fs.url || ''}
                     onChange={(evt) => {
                       this.setState({url: evt.target.value})
                     }}

diff --git a/lib/manager/containers/ActiveFeedVersionNavigator.js b/lib/manager/containers/ActiveFeedVersionNavigator.js
@@ -39,7 +39,9 @@ const mapStateToProps = (state, ownProps) => {
     }
   }
   const { jobs } = state.status.jobMonitor
-  const validationJob = feedVersionIndex >= 1 && jobs.find(j => j.type === 'VALIDATE_FEED' && j.feedVersion.id === feedVersions[feedVersionIndex - 1].id)
+  const validationJob = feedVersionIndex >= 1
+    ? jobs.find(j => j.type === 'VALIDATE_FEED' && j.feedVersion.id === feedVersions[feedVersionIndex - 1].id)
+    : null
   return {
     feedVersionIndex,
     validationJob,