Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timetable Editor: clicking away from a cell reverts to previous value #562

Closed
landonreed opened this issue Apr 23, 2020 · 1 comment · Fixed by #563
Closed

Timetable Editor: clicking away from a cell reverts to previous value #562

landonreed opened this issue Apr 23, 2020 · 1 comment · Fixed by #563
Assignees

Comments

@landonreed
Copy link
Contributor

While editing trips in the timetable editor, clicking away from a cell you are editing will cause the cell to revert to the previous value, rather than keep the edited value. A user must press Enter to keep the edited value, but this is not intuitive to a large number of users. We should add this.save() to occur when the cell is unfocused (the this.save() call on Enter keypress is visible in the code snippet below):

case 13: // Enter
evt.preventDefault()
if (isFocused) {
this.beginEditing()
}
// handle shift
if (evt.shiftKey) {
this.save()
offsetScrollRow(-1)
} else {
this.save()
}

@landonreed
Copy link
Contributor Author

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants