Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow distance decay functions truncated at 120 minutes #677

Closed
abyrd opened this issue Jan 29, 2021 · 0 comments
Closed

Allow distance decay functions truncated at 120 minutes #677

abyrd opened this issue Jan 29, 2021 · 0 comments
Assignees

Comments

@abyrd
Copy link
Member

abyrd commented Jan 29, 2021

When using non-step decay functions with higher cutoffs (e.g. logistic decay with cutoff over 60 minutes), an analysis may fail with the error "Distance decay function must reach zero at or before 120 minutes." This is one of several general assertions that are checked on any decay function, but this one can easily fail on reasonable inputs. We should tolerate functions that are still above zero at 120 minutes.

Nonetheless, as this may produce surprising results we will want to show a warning to the user (e.g. in single point results). But once you're aware of the situation, the result is a straightforward interaction with our usual 120 minute travel time cap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants