-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show message for disabled cookies #91
Comments
Like you said, cookies settings depend of the user and can be different for each domain. I think it's related to the cookies consent part and write a warning log in the console would be enough. Of course, the documentation has to highlight this issue to inform developers that cookies are required for a normal use. If we want handle cookie consent issue we have to do it properly (providing an easy way to enable them) else, what's the point to display an element that is not usable (we could hide it and display an alert message)? Moreover, login-fire inherits this issue from Google Signin button (and Firebase Auth) so, "it's not our problem". |
I agree that there's a very limited amount of things we can do to deal with this but I also think that the developer and/or end user won't care why it doesn't work. They'll just know that it doesn't work. Firing a Maybe showing a message is too much since it may differ based on others' implementation - not sure. |
You could fire an event with an error code based on the FirebaseError format ("login-fire/cookies-disabled") each time a sign in attempt fails using the |
We should add a message and/or fire an event when cookies are not enabled. We would still have some issues for when they are enabled for some domains and not others.
Related
The text was updated successfully, but these errors were encountered: