Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is Amazing! #62

Open
ianyepan opened this issue Feb 11, 2021 · 7 comments
Open

This is Amazing! #62

ianyepan opened this issue Feb 11, 2021 · 7 comments

Comments

@ianyepan
Copy link

May I ask what API you use? Is it an official browser version of VSCode provided by Microsoft? I would like to read more about it.

@conwnet
Copy link
Owner

conwnet commented Feb 11, 2021

Now github1s is based VS Code 1.52.1, VS Code can built for an browser version officially, we used some build scripts is from Code Server, the core work in github1s is impelementing an VS Code extension who provide the custom file IO interface with GitHub REST API, we will upgrade to the GraphQL API to improving user experience in the furture.

@pavelloz
Copy link

Agreed, this project is awesome. Good job.

This is this rare occasion when i see a project and say: Im going to use this.

PS. If you are taking feature requests: Search (shift+cmd+f) :)

@ajthinking
Copy link

+1! Mind blown 🔥 🔥 🔥 🔥 🔥 🔥

@Felx-B
Copy link

Felx-B commented Feb 12, 2021

Hi there,
Thank you @conwnet for this amazing project !
If you want you can also use my work on https://github.com/Felx-B/vscode-web
I compile vscode for browser and provide it through npm package.

This way you can reduce your compilation time and avoid all vscode requirement for building your project.

Also, if you need some help to build the search feature I'd love to help !

@xcv58
Copy link
Collaborator

xcv58 commented Feb 12, 2021

Hi there,
Thank you @conwnet for this amazing project !
If you want you can also use my work on https://github.com/Felx-B/vscode-web
I compile vscode for browser and provide it through npm package.

This way you can reduce your compilation time and avoid all vscode requirement for building your project.

Also, if you need some help to build the search feature I'll love to help !

+1 for this. I want to suggest using your library as well. There are still some unclear parts like bundled extensions, URL parsing.

@conwnet conwnet closed this as completed Feb 12, 2021
@conwnet conwnet reopened this Feb 12, 2021
@conwnet
Copy link
Owner

conwnet commented Feb 12, 2021

nice work, maybe we have to do some change for custom extensions

@eric-burel
Copy link

For googlers, link to the documentation that explains how it works: https://github.com/conwnet/github1s/blob/master/docs/guide.md

This is brilliant work with an elegant JAMstack approach. Github1s has become part of my daily routine literally immediately! Excellent when you want to dig the code of open source projects you rely on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants