Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make struct base public to allow creation of custom dialects #53

Open
sharpner opened this issue Oct 28, 2014 · 3 comments
Open

Make struct base public to allow creation of custom dialects #53

sharpner opened this issue Oct 28, 2014 · 3 comments

Comments

@sharpner
Copy link

Is there any reason to make base private?

@mantenie
Copy link

👍

@coocood
Copy link
Owner

coocood commented Nov 8, 2014

You can just copy and paste the code in base to create custom dialects.

@coocood
Copy link
Owner

coocood commented Nov 8, 2014

Well, I took a look at it again, it doesn't work.
I made those structs and functions private to avoid breaking the API when I refactor the code.
I think the best way to create your custom dialect is to fork the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants