Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DRF social authentication #3658

Open
franciscouzo opened this issue Mar 29, 2022 · 1 comment
Open

Add support for DRF social authentication #3658

franciscouzo opened this issue Mar 29, 2022 · 1 comment

Comments

@franciscouzo
Copy link

Description

Add support for DRF social authentication

Rationale

https://github.com/iMerica/dj-rest-auth supports social authentication, which is currently supported on the Django application, but not on the DRF one.
Besides that, I think the API should support another way of authentication besides tokens, JWT for example, since it's possible to have them expire for example.

@Andrew-Chen-Wang
Copy link
Contributor

I'm -1 on this

As the maintainer of SimpleJWT which is what dj rest auth depends on, I don't really like social authentication via SimpleJWT for security reasons on a community scale (many devs do security well; in light of recent events and just historically, and the fact that some devs will gloss over security holes or parts they're unaware of, I'm not advocating for dj rest auth be included in cookiecutter django)

I agree the default DRF tokens module isn't great and having SimpleJWT to replace it is nice; however, I would say more people like django oauth toolkit for its complete oauth methods. Because of two diff packages for one common goal, let's also leave the drf token module in place. It's a really quick removal if you don't want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants