Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the media & static settings to the new unified STORAGES #4443

Closed
browniebroke opened this issue Jul 10, 2023 · 2 comments · Fixed by #4477
Closed

Migrate the media & static settings to the new unified STORAGES #4443

browniebroke opened this issue Jul 10, 2023 · 2 comments · Fixed by #4477

Comments

@browniebroke
Copy link
Member

Description

Django 4.2 introduced a unified STORAGES setting which unifies static & media setup and simplifies adding a custom storage that might be required by an application (e.g. private media).

Rationale

The DEFAULT_FILE_STORAGE and STATICFILES_STORAGE settings are now both deprecated and we should migrate to the new setting before Django 5.1

@thefunkinator
Copy link
Contributor

thefunkinator commented Jul 11, 2023

Hello @browniebroke ,
Currently I am working on it and it passed all the Templates Test Suit. But Generate project tests fails with django.db.utils.OperationalError: connection is bad: No such file or directory error message. (using test_bare.sh)
Do we need local database running? where am I wrong?

@browniebroke
Copy link
Member Author

Yes, this test script needs a database. You can see how it's used in our CI workflow, there is service which is started.

It's great that you're trying to test locally, but don't spend too much time on the non-docker tests, the setup can be quite complicated, they'll run on GitHub when you open a pull request.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants