Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode privileges .editorconfig over settings.json for single quotes #4512

Open
acyment opened this issue Aug 11, 2023 · 3 comments
Open

VSCode privileges .editorconfig over settings.json for single quotes #4512

acyment opened this issue Aug 11, 2023 · 3 comments
Labels

Comments

@acyment
Copy link

acyment commented Aug 11, 2023

What happened?

Pre-commit applies prettier with single quotes (per .pre-commit-config.yaml) but if prettier is applied in VSCode it will invariably apply double quotes (even when changing settings.json). The only way to make VSCode apply single quotes when applying Prettier is to add quote_type = single

Additional details

Host system configuration:
    Cookiecutter 2.1.1
    Ventura 13.5
    Python 3.11.4
    Docker version 24.0.2, build cb74dfc
    Docker Compose version v2.19.1
@acyment acyment added the bug label Aug 11, 2023
@browniebroke
Copy link
Member

Thanks for the report

The only way to make VSCode apply single quotes when applying Prettier is to add quote_type = single

Where should one set this? In editorconfig? That seems that it's a "proposed property"...

Have you tried to create a Prettier config file?

@acyment
Copy link
Author

acyment commented Aug 14, 2023 via email

@browniebroke
Copy link
Member

Would you like to send us a pull request to fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants