Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should test against production environment, not local #4878

Closed
acyment opened this issue Feb 20, 2024 · 2 comments
Closed

CI should test against production environment, not local #4878

acyment opened this issue Feb 20, 2024 · 2 comments
Labels
bug wontfix Wait a 10 days days and automatically close

Comments

@acyment
Copy link

acyment commented Feb 20, 2024

What happened?

CI scripts (I only checked Github and Gitlab) run tests against local.yml

What should've happened instead?

I believe it makes more sense for CI to run tests against production.yml

@acyment acyment added the bug label Feb 20, 2024
@browniebroke
Copy link
Member

The image from production.yml doesn't include development and test dependencies (e.g. pytest), so how do you suggest we run tests without them?

We do that intentionally to keep the production image small

@browniebroke browniebroke added the wontfix Wait a 10 days days and automatically close label Feb 23, 2024
Copy link
Contributor

github-actions bot commented Mar 3, 2024

As discussed, we won't be implementing this. Automatically closing.

@github-actions github-actions bot closed this as completed Mar 3, 2024
@browniebroke browniebroke closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug wontfix Wait a 10 days days and automatically close
Projects
None yet
Development

No branches or pull requests

2 participants