Rename SendInBlue ESP to Brevo #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized that this is breaking some other configs. I'll update this PR with the fixes in a bit. |
|
Fixed all the errors and tested that these changes do actually work for sends mails using Brevo. Anymail has also refactored to support the name change so it was fairly straightforward. |
browniebroke
changed the title
browniebroke
approved these changes
May 27, 2024
|
Thanks for this, I didn't know they changed their name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a really tiny change! SendInBlue renamed themselves to Brevo in 2023. I am simply suggesting that we reflect that in the cookiecutter.json so that users can see it when they're configuring a new project. I propose that we change the option name to
Brevo (Previously SendInBlue).Checklist:
Rationale
Moving forward, an increasing number of users will be familiar with 'Brevo' instead of 'SendInBlue' and might simply assume that django-cookiecutter (or rather AnyMail) doesn't support Brevo. This change would avoid confusion.