python 3.5+ updates and tidyups #1805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksmayo
commented
Dec 12, 2022
marksmayo
commented
- Fixed some f-strings
- Removed inheritance from object (python 3)
- added trailing commas where requested by pep8
- fixed an underline flake8 warning
- simplified some case statements
- black to reformat as per repo requirements
- Fixed some f-strings - Removed inheritance from object (python 3) - added trailing commas where requested by pep8 - fixed an underline flake8 warning - simplified some case statements - black to reformat as per repo requirements
|
looks like the hook/action for gitlab is failing? Not sure what's going on there? |
pytest needs binaryornot to run
used isort to automatically take care of it
kurtmckee
reviewed
Jun 6, 2023
There was a problem hiding this comment.
@audreyfeldroy @jensens @tmeckel
This PR can be closed, but not merged.
It is a reformatting PR that incorrectly reformats the code, causes dozens of flake8 lint failures, and much of which is re-reformatted by black.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.