Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Allow attribute will take precedence over 'allowfullscreen'. #1444

Closed
magnattic opened this issue Apr 26, 2022 · 1 comment
Closed

Comments

@magnattic
Copy link

Current Behavior

Using the lib in nextjs with react 18, I get the following warning in the browser console:

Allow attribute will take precedence over 'allowfullscreen'.

This is the code:

<ReactPlayer
  url={source}
  loop
  muted
  playing
  playsinline
  controls={false}
  className={styles.video}
  width="100%"
  height="100%"
  data-chromatic="ignore"
/>

Expected Behavior

No warning

Environment

  • Browser: latest Chrome
  • NextJS: 12.1.5
  • react-player: 2.10.0
  • react: 18.0.0

Other info

This might be relevant: https://stackoverflow.com/questions/57665508/how-to-resolve-allow-attribute-will-take-precedence-over-allowfullscreen-warni

@cookpete
Copy link
Owner

cookpete commented May 7, 2022

Fixed in 2.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants