Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen doesn't work in mobile browser #155

Closed
iam-peekay opened this issue Feb 16, 2017 · 4 comments
Closed

Fullscreen doesn't work in mobile browser #155

iam-peekay opened this issue Feb 16, 2017 · 4 comments

Comments

@iam-peekay
Copy link

hi @cookpete - not sure if this is a known issue or something I need to configure. Fullscreen functionality works great on desktop but doesn't seem to work in mobile browsers. I tried Chrome and Safari and neither seem to work. Any chance you know why?

@nikolas
Copy link
Contributor

nikolas commented Feb 16, 2017

Which mobile browsers and which devices have you tried this on? Fullscreen functionality on mobile OS's is a lot different than on the desktop, so I'm not surprised that there are issues.

@iam-peekay
Copy link
Author

@nikolas Chrome and Safari. iOS

@cookpete
Copy link
Owner

Fullscreen functionality is a separate beast from the ReactPlayer library. The demo page uses screenfull.js as an example of how to use the JS fullscreen API with ReactPlayer (which is not supported by iOS or Android) and the fullscreen buttons inside the player are powered by the various different APIs for each video type, which are out of our control.

Alternatively, this might be solved by just adding the allowfullscreen attribute in the right places.

@iam-peekay
Copy link
Author

@cookpete yep, feel free to close this issue. I learned that iOS Safari does not support the native Fullscreen API http://caniuse.com/#search=fullscreen (which is what screefull.js uses underneath to implement it's API).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants