Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onDuration event no longer fires for HLS videos hosted by Mux in 2.15.1 #1763

Closed
eikonomega opened this issue Mar 12, 2024 · 0 comments · Fixed by #1769
Closed

onDuration event no longer fires for HLS videos hosted by Mux in 2.15.1 #1763

eikonomega opened this issue Mar 12, 2024 · 0 comments · Fixed by #1769
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@eikonomega
Copy link

eikonomega commented Mar 12, 2024

Current Behavior

After the implementation of automatically using the Mux player for videos hosted on Mux, the onDuration event is no longer fired on iOS devices.

Expected Behavior

While I understand, and even appreciate the desire to automatically use the mux-player for mux hosted videos, this seems like it is pretty clear breaking change that should have necessitated a major SEMVER version and associated documentation. As it is, it broke an application of ours that was set to automatically accept 2.X versions of the package.

Using the mux player should be opt-in for the 2.X series or onDuration should continue to function as before. At a minimum, documentation should be provided on how to opt-out and continue to use the previous (file?) player.

Appreciate all your work.

Thanks!

Steps to Reproduce

  1. Update from 2.14.1 to 2.15.1
  2. Have a ReactPlayer element with a url that points to a Mux hosted video.
  3. Add an onDuration handler to your element.
  4. It won't be triggered on iOS devices.

Environment

  • URL attempting to play: any
  • Browser: Safari
  • Operating system: iOS
@luwes luwes self-assigned this Mar 14, 2024
@luwes luwes added the bug Indicates an unexpected problem or unintended behavior label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants