Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not firing onError properly when playing (autoplay) is true with Vimeo #411

Closed
Silviu-Marian opened this issue May 30, 2018 · 3 comments
Closed

Comments

@Silviu-Marian
Copy link

Hey there. Lovely work

I have a problem with this video https://player.vimeo.com/video/196716639

Code

<Player 
    url="https://vimeo.com/video/196716639" 
    playing 
    onError={() => console.warn('aaaa')} />

should warn. it doesn't. instead, if you try to pause and play it again, only then you get the following

player.js:2 Uncaught (in promise) Error: The video is private.
    at player.js:2
    at Array.forEach (<anonymous>)
    at y (player.js:2)
    at u (player.js:2)

I'm also tracking the problem here

vimeo/player.js#165

Not sure at this point if it's a problem with vimeo or react-player

@cookpete
Copy link
Owner

cookpete commented May 30, 2018

This definitely seems like a problem with the Vimeo Player API. ReactPlayer is already doing the ready().catch() suggestion from vimeo/player.js#165 (comment)

https://github.com/CookPete/react-player/blob/cfc0e2c9f510de6614d08f8f571b3de21bac1043/src/players/Vimeo.js#L35-L39

As well as binding to the error event:

https://github.com/CookPete/react-player/blob/cfc0e2c9f510de6614d08f8f571b3de21bac1043/src/players/Vimeo.js#L50

Not sure what else we can do.

@Silviu-Marian
Copy link
Author

They fixed it yesterday. Can we update to 2.6.2 please?

@cookpete
Copy link
Owner

They fixed it yesterday. Can we update to 2.6.2 please?

@Silviu-Marian This should happen automatically. The latest Vimeo SDK is always loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants