Proper error codes

[cookpete]

Further to #44, there is a need for more robust onError return values to align the different problems that can occur with the different players.

[rijk]

Also, the onError is not called when the URL returns a 404 (example: https://vimeo.com/235229611) or is not embeddable (403, example: https://vimeo.com/161597420).

Uncaught (in promise) Error: “https://vimeo.com/161597420” is not embeddable.
    at XMLHttpRequest.a.onload (player.js:2)

[rijk]

Above possibly related to vimeo/player.js#57

[rijk]

Here's a way to catch those errors: vimeo/player.js#165 (comment)

Should I make a PR?

[cookpete]

Also, the onError is not called when the URL returns a 404

This is now sorted by d34d228, but there is still a bug with the Vimeo API that renders the player useless after the initial error occurs: vimeo/player.js#166.

[rijk]

Yeah, the Vimeo player is pretty crap. I submitted like 4 issues in the last week 😛

[cookpete]

Closing this off for now as it is a very old issue that doesn't serve much of a purpose any more. Each player has an entirely different set of errors and things that can possibly go wrong. The current behaviour of just passing these errors through to onError is good enough for nearly 100% of use cases. The effort required to try and reconcile every possible error from every player into a common set just doesn't seem to justify the benefit.

If any problems come up regarding a specific error, then people can open a separate issue for it. PRs to improve error handling are always welcome.