Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Vidyard and Hubspot Video Support #735

Closed
josephfung opened this issue Nov 1, 2019 · 10 comments
Closed

Feature request: Add Vidyard and Hubspot Video Support #735

josephfung opened this issue Nov 1, 2019 · 10 comments

Comments

@josephfung
Copy link

It would be fantastic if support for Vidyard (which also powered Hubspot Video) were added. Happy to collaborate on making it happen as well.

In case it would help, here are some of the documentation pieces I would recommend referencing:

Vidyard Player API (responsive player layout), or
Vidyard Legacy Player API (non-responsive)

@JohnMusleh
Copy link

any plans or updates for this?

@cookpete
Copy link
Owner

I don't want to add support for other types of video before I refactor a bit to enable lazy loaded players. Right now the default export includes the code to play all types of URL, even if you are only ever using one type.

Just a case of getting enough free time...

@josephfung
Copy link
Author

josephfung commented Mar 25, 2020

@cookpete Thanks for the explanation, that's helpful to understand. Supporting better lazy-loading is a good call for this case.

I realize this is a side-project, would something like a bounty be of help?

FWIW I checked, but didn't see any Patreon, buymeacoffee, or other sponsorship links on your profile...happy to be pointed that way 👍

@cookpete
Copy link
Owner

@josephfung I've been meaning to for a long time. Just set one up now: https://www.patreon.com/cookpete

@josephfung
Copy link
Author

Great! Done!! Thanks again for the great component!

@cookpete
Copy link
Owner

@josephfung Try out some Vidyard URLs with react-player@2.0.0-alpha.1 and let me know if they work. 🎉

@josephfung
Copy link
Author

@cookpete Amazing! thank you! 🙏 Works perfectly!

I see there were a lot of changes to incorporate that lazy-loading too - both sets of changes are very much appreciated!

@cookpete
Copy link
Owner

Yeah the lazy players was a result of #738 so I figured the 2.0 alpha would be a good way to quickly get something working to you.

Glad to hear it's working. Thanks so much for becoming a patron! If you know any other formats of Vidyard URL that people may use, let me know so I can adjust the regex. 👍

@josephfung
Copy link
Author

Thanks - I'll check with the team.

Off the top of my head, the only variation I know of, is that people can set a vanity URL (so other than share.vidyard.com the domain could be something like videos.mydomain.com). Not as many people do that, though, so I'm not sure if it's really a big use-case.

Either way - this is great, thanks! We have a PR in code review already incorporating the new version :D

@cookpete
Copy link
Owner

@josephfung v2.0.0 is here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants