Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delfador's "Teaching" ability should affect allied units #31

Open
cooljeanius opened this issue Oct 30, 2022 · 5 comments
Open

Delfador's "Teaching" ability should affect allied units #31

cooljeanius opened this issue Oct 30, 2022 · 5 comments
Labels
enhancement New feature or request
Projects

Comments

@cooljeanius
Copy link
Owner

@knyghtmare often proposes this idea for HttT, but Delfador is present here, too, so this could serve as a proof-of-concept for it

@cooljeanius cooljeanius added the enhancement New feature or request label Oct 30, 2022
@cooljeanius
Copy link
Owner Author

ok so after looking how UtBS does "Teaching" it looks like this will be a little bit more complicated than I thought; there's one macro for the ability, and then another for the events, so it's more than just a simple matter of plopping them in the unit definition... (also Delfador is created in multiple places, so...)

@cooljeanius cooljeanius added this to To Do in Wesnoth UMC via automation Oct 31, 2022
Wesnoth UMC automation moved this from To Do to Done Nov 5, 2023
@cooljeanius
Copy link
Owner Author

OK so that was actually simpler than I thought; fixed via 38e9208.

@knyghtmare
Copy link
Contributor

This would have been better if HttT also gave it to Delfador

@cooljeanius
Copy link
Owner Author

cooljeanius commented Nov 5, 2023

This would have been better if HttT also gave it to Delfador

well they still can! Think of this as like a "proof of concept" to help convince mainline to make the change, too.

@cooljeanius
Copy link
Owner Author

...actually I'm going to reopen this, because in S15 Delfador is the only unit on his side, so the ability is useless to him. I'm going to want to modify the ability to allow it to apply to allied units (will require teaching myself more of the Lua API)

@cooljeanius cooljeanius reopened this Nov 7, 2023
Wesnoth UMC automation moved this from Done to To Do Nov 7, 2023
@cooljeanius cooljeanius changed the title Give Delfador "Teaching" (from UtBS) Delfador's "Teaching" ability should affect allied units Nov 7, 2023
@cooljeanius cooljeanius moved this from To Do to In Progress in Wesnoth UMC Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Wesnoth UMC
  
In Progress
Development

No branches or pull requests

2 participants