Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (v4) Source secret inputs on top of action menu #1240

Closed
JorrinKievit opened this issue Sep 22, 2023 · 5 comments · Fixed by #1250
Closed

[Bug]: (v4) Source secret inputs on top of action menu #1240

JorrinKievit opened this issue Sep 22, 2023 · 5 comments · Fixed by #1250
Labels

Comments

@JorrinKievit
Copy link

JorrinKievit commented Sep 22, 2023

Description

The inputs on a source page like Github App have a higher z-index than the action menu.

Minimal Reproduction (if possible, example repository)

  1. Go to any existing source
  2. Open action menu with "/" or clicking on the menu top left

Exception or Error

image

Version

v4.0.0-beta.43

@JorrinKievit JorrinKievit changed the title [Bug]: (v4) Source inputs over action menu [Bug]: (v4) Source secret inputs over action menu Sep 22, 2023
@JorrinKievit JorrinKievit changed the title [Bug]: (v4) Source secret inputs over action menu [Bug]: (v4) Source secret inputs on top of action menu Sep 22, 2023
@andrasbacsai
Copy link
Member

@chz Could you please check this?

It is a tricky one - at least for me. For the password fields, I use absolute position in a relative parent, to place the small eye icon inside the input box.

The Magicbar (vue) component is a fixed background with a fixed-positioned menu.

@chz
Copy link
Contributor

chz commented Sep 24, 2023

@chz Could you please check this?

It is a tricky one - at least for me. For the password fields, I use absolute position in a relative parent, to place the small eye icon inside the input box.

The Magicbar (vue) component is a fixed background with a fixed-positioned menu.

Yeap i will check and create PR

@chz
Copy link
Contributor

chz commented Sep 24, 2023

@andrasbacsai also i think, Maybe we must refactor this input component to use flex approach instead relative absolute. For future we can extend more and more icons left or right.

@andrasbacsai
Copy link
Member

@andrasbacsai also i think, Maybe we must refactor this input component to use flex approach instead relative absolute. For future we can extend more and more icons left or right.

Yes, I'm okay with it. It was just a quick solution from me. I'm open to any improvement here.

Would you like me to open an issue for it?

@chz
Copy link
Contributor

chz commented Sep 24, 2023

@andrasbacsai also i think, Maybe we must refactor this input component to use flex approach instead relative absolute. For future we can extend more and more icons left or right.

Yes, I'm okay with it. It was just a quick solution from me. I'm open to any improvement here.

Would you like me to open an issue for it?

Yeap create issue for that i will try to refactor input component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants