Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native link duplicates lines in Android project #62

Closed
alexsegura opened this issue Mar 4, 2018 · 5 comments
Closed

react-native link duplicates lines in Android project #62

alexsegura opened this issue Mar 4, 2018 · 5 comments
Assignees
Labels

Comments

@alexsegura
Copy link
Member

When running react-native link, some lines are duplicated in the Android project

modified:   android/app/build.gradle
modified:   android/app/src/main/java/fr/coopcycle/MainApplication.java
modified:   android/settings.gradle
$ git diff android/app/build.gradle
diff --git a/android/app/build.gradle b/android/app/build.gradle
index 3ff21d3..df94611 100644
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -152,6 +152,10 @@ android {
 }

 dependencies {
+    compile project(':tipsi-stripe')
+    compile project(':react-native-maps')
+    compile project(':react-native-locale-detector')
+    compile project(':react-native-keep-awake')
     compile project(':react-native-locale-detector')
     compile(project(':react-native-keep-awake')){
       exclude group: 'com.google.android.gms'

I think it is due to the Gradle plugin, React Native 0.54 has just been released, will give it a try.

@alexsegura alexsegura added the bug label Mar 4, 2018
@Atala
Copy link
Member

Atala commented Mar 4, 2018

I think I know where it comes from, let me have a look.

@Atala Atala self-assigned this Mar 4, 2018
@alexsegura
Copy link
Member Author

It looks like react-native link kind of "hangs": when I run the command, I have to hit enter to "finish" it.

@Atala
Copy link
Member

Atala commented Mar 5, 2018

The workaround I saw once isn't working.

Good news is there is PR waiting to be merged in react-native, just have to wait for it : facebook/react-native#18131

@alexsegura
Copy link
Member Author

Oh ok I thought the bug was only affecting us.
React Native 0.54 has just been released, let's wait a little more.

@Atala
Copy link
Member

Atala commented Apr 5, 2018

gr8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants