The plugin is giving errors and breaking the batch import of metadata when using it #6
Comments
ferrazpedro
changed the title
|
I'll take a look @ferrazpedro thanks for posting the issue. |
|
This should not happen, if there is some basic problem, like not finding the game, the extension should not crash and burn and stopping other metadata extensions to continue searching. |
|
@shakeyourbunny @ferrazpedro The issue should be resolved now in the latest release (v0.5.1). Please test and report back any errors you might find. Thanks! |
|
Not quite. Playnite version is 7.7, SGDB Metadata plugin is 0.5.1; my API key is set in the SGDB metadata options. https://i.imgur.com/ogxHZwN.png After manually updating 1954 Alcatraz, this happens in the log: Also In this case, the cover image was uploaded some time ago to steamgriddb and should have been downloaded properly. The game itself is a free game on Steam btw. |
|
@shakeyourbunny Should be good to go now! Thanks for the quick response. See https://github.com/cooperate/SteamGridDBMetadata/releases/tag/v0.5.2 |
|
did work for a moment, after that it shorted out. This is the Epic Store version of Torchlight II (any other games do not work either, but there is randomly added the search term "Dodo"). https://www.steamgriddb.com/api/v2/grids/epic/8e425d507bd6473dbb927f0fea8ef4f6?dimensions=600x900&styles=alternate produces HTTP error 404. Thank you for your efforts! |
|
It seems, the SGDB metadata extensions seems only work with Steam games, which is a bummer. Epic: does not work (see above) GOG: seems to work. itch.io: does not work. twitch: does not work. steam: seems to work (with 0.5.2). As I don't own accounts for Origin, UPlay, Bethesda, XBox or I don't trust the library importer (HumbleBundle), I strongly suspect that searching for metadata for these libraries are broken too. |
|
I tried with Katawa Shoujo, service failure |
|
@shakeyourbunny @vannessqn this was an api issue apparently, not a plugin issue. If you don't mind try again to see if it's working. |
|
Nope, just tried it with several games from libraries from not Steam or GOG; same issue is persisting. To make it clear, the result is HTTP 404 and ... why are there even for every shop extra artwork data. It may make sense, but I'd suggest to add a checkbox in the settings like which exactly handles that scenario, which is currently with 0.5.2 handled with a extension crash, because it expects JSON and tries to parse the 404 HTML response. If HTML is returned and the suggested option is not checked, it should return nothing and give the next metadata extension control to get proper data. In case this checkbox is checked and nothing is found on the Steam side... handle a non JSON response (HTML 404) and give the next metadata extension a chance to execute. Another option - this I had originally expected though - is that the extension just try to get Steam artwork for the game if the game is not a Steam game. If there are multiple matches (title; do a title sanitization, lowercase string and remove all non-numeric and non-letter characters, then compare), ask in a popup window. This should override (and automatically includes the "fall back to Steam" option). BTW there may be a memory leakage from this extension, after so about handling 360-500 games, PlayNite crashes with an out of memory exception, but I'm not really sure that this extension is the culprit; I have to do some digging for this (the only other manually added extensions is the SteamNite theme and the Universal SteamDB extension. Additional included metadata provider is IGDB, active library plugins are Battle.Net, GOG, Steam, Twitch, Epic). |
|
@shakeyourbunny I see what you're saying now yep! I'll need to an exception for supported platforms as it's definitley causing issues. I wouldn't be surprised if the memory leak is related to spam in the logs from that markup but it might not be. |
|
@shakeyourbunny https://github.com/cooperate/SteamGridDBMetadata/releases/tag/0.5.3 It falls back to my "fuzzy search" now if the game platform is not available. Until I find time to implement a more elegant solution (ie "this game is probably not available, let's not download the art for game y on game x) this should probably do the trick. Test and verify. Thanks for your help! |
|
Seems to be working now, thank you for your efforts! |
|
Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Good Evening!
When I try to download metadata in batches with the plugin enabled, a lot of times it just completely breaks the process for some games and gives this in my log:
Error - 14072020.log
The text was updated successfully, but these errors were encountered: