Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the tail re unit #8

Closed
debraj135 opened this issue Nov 13, 2021 · 6 comments
Closed

Question about the tail re unit #8

debraj135 opened this issue Nov 13, 2021 · 6 comments

Comments

@debraj135
Copy link

Is there a reason why the order of h_re and h_share are swapped here as compared to over here ?

Thanks for any help.

@Coopercoppers
Copy link
Owner

Part of the reason is in the justification part of readme.md in pfn-nested folder.

Also, since head to head and tail to tail are coming for different results, using the same feature might not be optimal.
We learn that lesson from the previous works where people simply use the same feature for ner and re.

Empirically speaking, switching them leads to faster convergence In our experiment. So we stick with this formula.

@debraj135
Copy link
Author

Thank you for your prompt response. In terms of best performance, is there a significant difference between the two settings? And if yes, can you please elaborate?

@Coopercoppers
Copy link
Owner

Coopercoppers commented Nov 14, 2021

Here is the thing, industry people used pfn on their Chinese dataset and the result is super low because there are so many head-overlap triples in their dataset. so I provided them with pfn-nested, the result got normal under pfn-nested. All in all, pfn-nested is designed mainly to cover the issue of nested triple prediction.

As for performance in current dataset, I only used it on scierc, the result is displayed in the main page though. I did try to use it on ace05, but I ran into oom error with batch size 20.

There is no systematic evaluation of pfn-nested though, you can verify the performance yourself if you’re interested.

@debraj135
Copy link
Author

Thank you. This answers my questions.

@debraj135
Copy link
Author

And by the way, this work is indeed truly impressive. Best wishes on further explorations!

@Coopercoppers
Copy link
Owner

ok, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants