Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test library #75

Closed
sandfox opened this issue Jul 5, 2014 · 5 comments
Closed

Replace test library #75

sandfox opened this issue Jul 5, 2014 · 5 comments
Assignees

Comments

@sandfox
Copy link
Collaborator

sandfox commented Jul 5, 2014

The current test library has been depreciated for around 3 years but somehow still works. We should probably replace it with something maintained like tap or lab etc before it gets broken by a new release of node.

Open to suggestions or PRs for this. It's going to be a fair chunk of work to rewrite everything I suspect.

@sandfox sandfox added this to the V3.0.0 milestone Jul 5, 2014
@felixfbecker
Copy link
Contributor

@sandfox I'm trying to take a shot at it because my other PR is finished but I cannot run the expresso tests on Windows. However I don't understand the tests at all, some inline documents would have been helpful. There is no such thing as beforeExit and mocha, instead you call done with either an error or without one for async tests. The way you iterate synchronously with a for loop and then trigger async actions and the assert synchronously doesn't make sense to me...

Maybe you have some input, otherwise I will just take the existing test descriptions and write new ones for them, make them pass on the current version and then test against my prototype-PR.

@felixfbecker
Copy link
Contributor

But I'm not even sure what expands to max limit even means - what is it in this context?

@felixfbecker
Copy link
Contributor

Btw mocha needs at least Node 0.8, which means we cannot test on Travis for Node 0.2 anymore.

@sandfox
Copy link
Collaborator Author

sandfox commented Jan 11, 2016

Ok, I'll have a look and see if I shed any further light on that stuff and drop it here

I'm totally fine with dropping testing for everything pre-0.8 - as long as the new tests pass I'm happy with line of reasoning that we haven't broken backwards compatibility for library consumers (which ever ones are still out there on old skool node versions), and when the "class" stuff lands, as long as the tests still pass then in theory we still won't have broken b/c.

@sandfox sandfox modified the milestones: v2.4.0, V3.0.0 Jan 11, 2016
@sandfox sandfox mentioned this issue Jan 11, 2016
4 tasks
@sandfox sandfox modified the milestones: V3.0.0, v2.4.0 Jan 12, 2016
@sandfox sandfox self-assigned this Jan 13, 2016
@sandfox sandfox modified the milestones: 2.4.1, v2.4.0 Jan 18, 2016
@sandfox sandfox removed this from the 2.4.1 milestone Feb 20, 2016
@sandfox
Copy link
Collaborator Author

sandfox commented Sep 18, 2016

done in v3

@sandfox sandfox closed this as completed Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants