-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace test library #75
Comments
@sandfox I'm trying to take a shot at it because my other PR is finished but I cannot run the expresso tests on Windows. However I don't understand the tests at all, some inline documents would have been helpful. There is no such thing as Maybe you have some input, otherwise I will just take the existing test descriptions and write new ones for them, make them pass on the current version and then test against my prototype-PR. |
But I'm not even sure what expands to max limit even means - what is it in this context? |
Btw mocha needs at least Node 0.8, which means we cannot test on Travis for Node 0.2 anymore. |
Ok, I'll have a look and see if I shed any further light on that stuff and drop it here I'm totally fine with dropping testing for everything pre-0.8 - as long as the new tests pass I'm happy with line of reasoning that we haven't broken backwards compatibility for library consumers (which ever ones are still out there on old skool node versions), and when the "class" stuff lands, as long as the tests still pass then in theory we still won't have broken b/c. |
done in v3 |
The current test library has been depreciated for around 3 years but somehow still works. We should probably replace it with something maintained like tap or lab etc before it gets broken by a new release of node.
Open to suggestions or PRs for this. It's going to be a fair chunk of work to rewrite everything I suspect.
The text was updated successfully, but these errors were encountered: