[REF] Split cooperator_website into cooperator_website_recaptcha #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Codecov Report
@@ Coverage Diff @@
## 12.0-komunigi #312 +/- ##
================================================
Coverage ? 54.20%
================================================
Files ? 116
Lines ? 4044
Branches ? 614
================================================
Hits ? 2192
Misses ? 1774
Partials ? 78 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
victor-champonnois
approved these changes
Apr 15, 2022
Comment on lines
+15
to
+18
| redirect = "cooperator_website.becomecooperator" | ||
|
|
||
| is_company = kwargs.get("is_company") == "on" | ||
|
|
There was a problem hiding this comment.
Arf this duplication is painful but I don't see a way around it, the original controller really needs some serious refactoring !
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #283
Odoo task (if applicable)
Checklist before approval