Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] easy_my_coop: Fix name computation crash #330

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

carmenbianca
Copy link
Member

Don't use value from self when looping over a list

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=8728&model=project.task&view_type=form&menu_id=

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

Don't use value from self when looping over a list

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Copy link
Member

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@remytms
Copy link
Member

remytms commented Jun 20, 2022

/ocabot merge patch

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-330-by-remytms-bump-patch, awaiting test results.

@github-grap-bot github-grap-bot merged commit b9459fb into 12.0 Jun 20, 2022
@github-grap-bot github-grap-bot deleted the 12.0-fix-singleton-bug branch June 20, 2022 08:13
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 7f47ce8. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants