Create USAGE.rst #346

victor-champonnois · 2022-07-14T08:00:51Z

I know localization are needed for cooperator_website, is it also the case for cooperator ?

codecov-commenter · 2022-07-14T08:05:00Z

Codecov Report

Merging #346 (f0d71d1) into 12.0 (35443a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             12.0     #346   +/-   ##
=======================================
  Coverage   56.58%   56.58%           
=======================================
  Files          97       97           
  Lines        3524     3524           
  Branches      560      560           
=======================================
  Hits         1994     1994           
  Misses       1451     1451           
  Partials       79       79

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

enricostano · 2022-07-18T11:58:26Z

cooperator/readme/USAGE.rst

@@ -0,0 +1,8 @@
+A localization module is needed with this module.
+
+The following localization modules are available this repository:


Suggested change

The following localization modules are available this repository:

The following localization modules are available in this repository:

robinkeunen · 2022-07-26T13:50:30Z

cooperator/readme/USAGE.rst

@@ -0,0 +1,8 @@
+A localization module is needed with this module.


What happens when none is installed ? Do we get a nice error ?

No, there is no error.

Actually, this is part to the configuration of cooperator that is explained in the functional documentation. Since the documentation is linked in the readme, maybe this Usage file is not required. Or we could just make a usage file that points to the documentation ?

As discussed :

a link to the documentation is 👍

mentioning that localization is needed is nice

better solution is to make localization modules auto_installed

victor-champonnois · 2022-07-26T15:10:17Z

todo (following discussion with @robinkeunen):

point to the functional doc in usage.rst
add auto-install in the l10n_xx_cooperator modules

victor-champonnois · 2022-09-01T12:13:13Z

todo (following discussion with @robinkeunen):
* point to the functional doc in usage.rst

* add auto-install in the l10n_xx_cooperator modules

Done

robinkeunen · 2022-09-02T08:44:18Z

l10n_be_cooperator/__manifest__.py

@@ -35,4 +35,5 @@
    ],
    "installable": True,
    "application": False,
+    "auto-install": True,


Is cooperator_website needed in the depends here ? If so, the localization will only be installed if all 4 modules are installed.

Besides the auto_install feature, it also means we can't install the localization without installing cooperator_website.

Same story for other localizations.

En passant, l10n_be_invoice_bba is empty in v14 so we can skip that dependency there.

Is cooperator_website needed in the depends here ? If so, the localization will only be installed if all 4 modules are installed.

Besides the auto_install feature, it also means we can't install the localization without installing cooperator_website.

Same story for other localizations.

Yes it is needed because the module overload the subscription form template. I don't see a way around this now, maybe cooperator_website should also be auto-install ?

En passant, l10n_be_invoice_bba is empty in v14 so we can skip that dependency there.

Noted

Ok then I think you should add in known_caveats of ROADMAP.rst that this module will have to be split if someone needs to install one module without the other.

victor-champonnois · 2022-09-02T09:50:32Z

PR forward ported here : #368

robinkeunen · 2022-09-05T15:08:39Z

/ocabot merge minor

github-grap-bot · 2022-09-05T15:08:44Z

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-346-by-robinkeunen-bump-minor, awaiting test results.

Signed-off-by robinkeunen

github-grap-bot · 2022-09-05T15:13:33Z

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-346-by-robinkeunen-bump-minor, awaiting test results.

Signed-off-by robinkeunen

github-grap-bot · 2022-09-05T15:17:35Z

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-346-by-robinkeunen-bump-minor, awaiting test results.

Signed-off-by robinkeunen

github-grap-bot · 2022-09-05T15:23:39Z

@robinkeunen The merge process could not be finalized, because command git push origin 12.0-ocabot-merge-pr-346-by-robinkeunen-bump-minor:12.0 failed with output:

To https://github.com/coopiteasy/vertical-cooperative
 ! [rejected]          12.0-ocabot-merge-pr-346-by-robinkeunen-bump-minor -> 12.0 (non-fast-forward)
error: failed to push some refs to 'https://***@github.com/coopiteasy/vertical-cooperative'
hint: Updates were rejected because a pushed branch tip is behind its remote
hint: counterpart. Check out this branch and integrate the remote changes
hint: (e.g. 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

robinkeunen · 2022-09-05T15:41:13Z

/ocabot merge minor

github-grap-bot · 2022-09-05T15:41:18Z

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-346-by-robinkeunen-bump-minor, awaiting test results.

github-grap-bot · 2022-09-05T15:47:18Z

Congratulations, your PR was merged at 71ca25b. Thanks a lot for contributing to coopiteasy. ❤️

victor-champonnois requested a review from robinkeunen July 14, 2022 08:00

github-grap-bot added the needs review label Jul 14, 2022

enricostano reviewed Jul 18, 2022

View reviewed changes

robinkeunen reviewed Jul 26, 2022

View reviewed changes

huguesdk force-pushed the 12.0 branch from 150651f to 2d9d876 Compare August 22, 2022 09:11

victor-champonnois requested review from enricostano and robinkeunen and removed request for enricostano September 1, 2022 12:13

robinkeunen requested changes Sep 2, 2022

View reviewed changes

robinkeunen requested review from robinkeunen and removed request for enricostano September 5, 2022 15:08

robinkeunen approved these changes Sep 5, 2022

View reviewed changes

github-grap-bot added a commit that referenced this pull request Sep 5, 2022

Merge PR #346 into 12.0

585f7a8

Signed-off-by robinkeunen

github-grap-bot added the bot is merging ⏳ label Sep 5, 2022

github-grap-bot added a commit that referenced this pull request Sep 5, 2022

Merge PR #346 into 12.0

476cdf4

Signed-off-by robinkeunen

github-grap-bot added a commit that referenced this pull request Sep 5, 2022

Merge PR #346 into 12.0

c61c470

Signed-off-by robinkeunen

github-grap-bot removed the bot is merging ⏳ label Sep 5, 2022

robinkeunen force-pushed the 12.0-add-usage-localization-module branch from f0d71d1 to 5b63655 Compare September 5, 2022 15:40

victor-champonnois and others added 2 commits September 5, 2022 17:40

Create USAGE.rst

5c7247a

[ADD] newsfragment

864b693

victor-champonnois added 2 commits September 5, 2022 17:40

Add auto-install to localization modules

db5d37a

[UPD] ROADMAP.rst: need to split localization modules

425d9a5

robinkeunen force-pushed the 12.0-add-usage-localization-module branch from 5b63655 to 425d9a5 Compare September 5, 2022 15:41

github-grap-bot added the bot is merging ⏳ label Sep 5, 2022

github-grap-bot merged commit 5988d56 into 12.0 Sep 5, 2022

github-grap-bot deleted the 12.0-add-usage-localization-module branch September 5, 2022 15:47

github-grap-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create USAGE.rst #346

Create USAGE.rst #346

victor-champonnois commented Jul 14, 2022 •

edited

Loading

codecov-commenter commented Jul 14, 2022 •

edited

Loading

enricostano Jul 18, 2022

robinkeunen Jul 26, 2022

victor-champonnois Jul 26, 2022 •

edited

Loading

robinkeunen Jul 26, 2022

victor-champonnois commented Jul 26, 2022

victor-champonnois commented Sep 1, 2022

robinkeunen Sep 2, 2022

robinkeunen Sep 2, 2022

victor-champonnois Sep 2, 2022 •

edited

Loading

victor-champonnois Sep 2, 2022

robinkeunen Sep 2, 2022

victor-champonnois Sep 2, 2022

victor-champonnois commented Sep 2, 2022

robinkeunen commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

robinkeunen commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

		@@ -0,0 +1,8 @@
		A localization module is needed with this module.

		The following localization modules are available this repository:

Create USAGE.rst #346

Create USAGE.rst #346

Conversation

victor-champonnois commented Jul 14, 2022 • edited Loading

codecov-commenter commented Jul 14, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois Jul 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois commented Jul 26, 2022

victor-champonnois commented Sep 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois Sep 2, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victor-champonnois commented Sep 2, 2022

robinkeunen commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

robinkeunen commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

github-grap-bot commented Sep 5, 2022

victor-champonnois commented Jul 14, 2022 •

edited

Loading

codecov-commenter commented Jul 14, 2022 •

edited

Loading

victor-champonnois Jul 26, 2022 •

edited

Loading

victor-champonnois Sep 2, 2022 •

edited

Loading