Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests do not test code that creates queues #106

Closed
Letsch22 opened this issue Dec 19, 2019 · 1 comment
Closed

Integration tests do not test code that creates queues #106

Letsch22 opened this issue Dec 19, 2019 · 1 comment

Comments

@Letsch22
Copy link
Contributor

Letsch22 commented Dec 19, 2019 •
edited
Loading

The integration tests do not appear to test the underlying code that creates the SQS queues. Instead, they rely on running shell scripts that directly invoke the AWS CLI. For example, from scripts/create-queues.sh:

aws sqs --endpoint-url ${AWS_ENDPOINT_URL} create-queue

Is this not simply creating the queue via the AWS CLI? How is this testing the code contained in packages/serverless-offline-sqs/src/index.js that is responsible for creating the queues?
@Letsch22 Letsch22 changed the title Integration tests do not test underlying code Integration tests do not test code that creates queues Dec 19, 2019
@Letsch22
Copy link
Contributor Author

Addressed by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Letsch22