Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learner selection & construction #1

Closed
jakob-r opened this issue Aug 23, 2016 · 10 comments
Closed

Learner selection & construction #1

jakob-r opened this issue Aug 23, 2016 · 10 comments
Assignees

Comments

@jakob-r
Copy link
Contributor

jakob-r commented Aug 23, 2016

No description provided.

@jakob-r jakob-r self-assigned this Aug 23, 2016
@berndbischl
Copy link
Contributor

for classif: i would always set the predict type to "prob", i dont think there is a downside to this

@berndbischl
Copy link
Contributor

what is harder is how we let the user select the params

@jakob-r jakob-r removed their assignment Aug 23, 2016
@berndbischl
Copy link
Contributor

IMHO the learners should be selected on their own page?
they already seem to influence multiple things?

@jakob-r
Copy link
Contributor Author

jakob-r commented Aug 23, 2016

IMHO we have three options

  1. Let the user enter the par.vals list directly
  2. Have some hand coded interfaces for the most popular learners
  3. Parse the par.set of the Learner and generate a shiny UI based on that. For every param type there will be a specific sidebarPanel and so on. Tedious but doable

@berndbischl
Copy link
Contributor

how about we have a textbox per selected learner, where the user enters the parvals, simply as an expression. thats simple, but flexible. but while that learner is in focus / selected, we also display its param set. so i can see how stuff is named / called.

later on the UI could be improved.

@PhilippPro
Copy link
Contributor

PhilippPro commented Aug 23, 2016

there are some learners (e.g. knn, lvq1 and rferns) that do not have the property "prob".

On the three options: I would prefer option 3. Maybe the interface for the parameters could be created automatically after setting an algorithm (e.g. with help of getParamSet). I do not know if this is possible in shiny.

@berndbischl
Copy link
Contributor

On the three options: I would prefer option 3. Maybe the interface for the parameters could be created automatically after setting an algorithm (e.g. with help of getParamSet). I do not know if this is possible in shiny.

of course one can program this, also with shiny. but it will be work. i would suggest to do the simpler thing first....

@florianfendt florianfendt changed the title implement learner selection Learner selection & construction Oct 27, 2016
@florianfendt
Copy link
Contributor

Since #24 we have a learner tab, where all learners for the ongoing steps are selected and constructed.
For each learner the user can see the ParamSet and then enter the par.vals as raw text.
If a classification learner supports probs the user can select the predict type.
Next steps:

  • implement sliders and buttons for the different param types
  • Allow predict.type = "se" for regression learners

@Coorsaa
Copy link
Owner

Coorsaa commented Nov 9, 2016

just found a small bug: when changing a param of a learner in the learner section, automatically the tab of the first learner is selected again.

@Coorsaa
Copy link
Owner

Coorsaa commented Jan 21, 2017

this issue seems to be obsolete since PR #63

@Coorsaa Coorsaa closed this as completed Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants