fix(updating): unset invalid last answers #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisp
force-pushed
the
fix/unset-invalid-last-answers
branch
from
e4e65a9
to
0889f52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1589 +/- ##
==========================================
- Coverage 97.33% 97.22% -0.11%
==========================================
Files 48 48
Lines 4685 4719 +34
==========================================
+ Hits 4560 4588 +28
- Misses 125 131 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sisp
force-pushed
the
fix/unset-invalid-last-answers
branch
from
0889f52
to
eaa4e25
Compare
|
I have sadly resorted to Line 422 in eaa4e25 because I don't see an easy opportunity for reducing the complexity of this method. |
sisp
force-pushed
the
fix/unset-invalid-last-answers
branch
from
eaa4e25
to
5f67017
Compare
sisp
force-pushed
the
fix/unset-invalid-last-answers
branch
from
5f67017
to
f237c94
Compare
yajo
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a bug related to handling invalid last answers which caused Copier to raise an exception while updating a project. The solution is to unset a previously recorded answer if parsing or validation fails. For instance, a choice question with choice item validators will fall back to either its default value or the first enabled choice item. In interactive mode without the
--defaultsswitch, the user will be given the opportunity to select a valid answer again.Fixes #1483.