Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Root level __init__.py #56

Closed
pykong opened this issue Jul 27, 2019 · 1 comment
Closed

Bug - Root level __init__.py #56

pykong opened this issue Jul 27, 2019 · 1 comment

Comments

@pykong
Copy link
Collaborator

pykong commented Jul 27, 2019

I have not been able to either user pyannotate or MonkeyType to add type hints to copier's code.

In the issue I opened on MonkeyType it was suggested this being due to the __init__.py
present at the root level of copier:
Instagram/MonkeyType#139

Similar problems exist for pyannotate:
dropbox/pyannotate#61

I do not possess the experience with developing python packages to judge whether the root level __init__.py should be there or not. However, it should be considered in light of the problems I have experienced.

@pykong pykong changed the title Bug - root level __init__.py Bug - Root level __init__.py Jul 27, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

Frankly, I didn't know it could be a problem. Removing it will force you to install the package before running the tests (pip install -e . once is enough) but if it's preventing running those tools, I think it should be done.

@ghost ghost closed this as completed in 5d15e9d Aug 20, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant