-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copilot-c99
: Can C99 generator declare stream functions as static?
#507
Comments
That's a good point. I see no reason to make them public and I agree that it would be better to make functions static. |
copilot-c99
: Can C99 generator declare stream functions as static?
@fdedden Did you have a chance to look into this? Do you think this can be done without negative impact? |
Dear Simon, thank you for the suggestion. Yes, it is indeed better to have these functions defined as The addition of the keyword has already been implemented in January for the 3.18 release of Copilot (see 6779d03) to comply with the MISRA C coding standard. It should suffice for you to upgrade to at least the 3.18 release. Please let me know if you have any more questions. Reference to the C99 standard, section 6.2.2 and 6.2.4: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf. |
I think I only added it for variables, not functions, didn't I? |
No? The commit I mentioned (6779d03) adds The variables have been defined static since I wrote the first version of the C99 backend. Let me also ping @simondlevy, since I forgot to do that in my initial reply. |
You're right. I completely forgot! 😮 |
@simondlevy have you been able to try with the latest version? |
I bought a new computer recently and installed Copilot on it following the instructions as usual. When I tried the heater example, the compiled C header still did make the declarations static. |
But were functions static or not? That was the issue, wasn't it? |
@simondlevy Just to confirm: your issue has been solved, right? |
C code output by Copilot declares variables static but functions global; e.g.:
Global declaration of functions causes duplicate-name conflicts when linking together multiple C sources output by Copilot. Issue could probably be handled by a script, but I'm wondering why the local functions are being declared without static to begin with.
The text was updated successfully, but these errors were encountered: