Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing adding timeline events and creating new timeline #1247

Merged
merged 2 commits into from Oct 10, 2022
Merged

Fixing adding timeline events and creating new timeline #1247

merged 2 commits into from Oct 10, 2022

Conversation

GreenCloversGames
Copy link
Contributor

No description provided.

@GreenCloversGames
Change calls to bind
f9a5aea 
Replace ".call" to ".bind", which allows the objects to stay Callable and keep their parameters.
@GreenCloversGames
Fixed new timeline creation
64fd2a6 
Added some code to allow new timelines to save as an empty file.
@coppolaemilio
Copy link
Collaborator

Thanks! I'll review it now :)

coppolaemilio
coppolaemilio reviewed Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@coppolaemilio coppolaemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about the change in the TimelineResourceSaver.gd

addons/dialogic/Resources/TimelineResourceSaver.gd Show resolved Hide resolved
@coppolaemilio coppolaemilio merged commit 562c5ad into dialogic-godot:main Oct 10, 2022
@exelia-antonov exelia-antonov mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coppolaemilio coppolaemilio coppolaemilio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GreenCloversGames @coppolaemilio