Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix History.gd [br] resolve. #1339

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix History.gd [br] resolve. #1339

merged 1 commit into from
Dec 2, 2022

Conversation

eaganlai
Copy link

@eaganlai eaganlai commented Dec 2, 2022 •
edited

For issue #1338

@eaganlai eaganlai mentioned this pull request Dec 2, 2022
Closed
zaknafean
zaknafean approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary since the [br] is handled in the display parser of text bubble, and was left out of the history parser.

@zaknafean zaknafean merged commit bc0c9dc into dialogic-godot:dialogic-1 Dec 2, 2022
@coppolaemilio
Copy link
Collaborator

Thank you both!

@eaganlai eaganlai deleted the dialogic-1 branch December 4, 2022 20:11
@eaganlai eaganlai restored the dialogic-1 branch December 4, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaknafean zaknafean zaknafean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eaganlai @coppolaemilio @zaknafean