Fixed Speed tag resolve in HistoryRow #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Speed tag resolve in HistoryRow with Regex. Also refactored [BR} replacement for better readability.
This reverts commit 7936483.
Since resolving it in History.gd will disable the speed effect. The text will be resolved in the HistoryRow.gd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since resolving it in History.gd will disable the speed effect. I am resolving it in the HistoryRow.gd instead.
The speed tag is removed using Regex. It will cater below situation:
[speed=1234567890]
[speed=23 ]
[ speed=23]
[speed = 23]
[ speed = 23 ]
But not
[custom_effect speed=23 span=23]
Just in case anyone wants to use speed as an argument for a custom RichTextEffect.