Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few editor startup errors #1400

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

vmedea
Copy link
Contributor

@vmedea vmedea commented Jan 12, 2023

Fix a few SCRIPT ERRORs at startup:

  • Don't return value from create_drag_and_drop_event, which returns void
  • Fix Category enum value MAIN -> Main
  • Update set_drag_forwarding and associated signatures: There were some changes to set_drag_forwarding in Godot 4:
    • Control.set_drag_forwarding takes three callables instead of an object
    • _can_drop_data_fw, _drop_data_fw don't have a from_control argument anymore

This function returns void, so don't return a value.
There were some changes to set_drag_forwarding in Godot 4:

- `Control.set_drag_forwarding` takes three callables
- `_can_drop_data_fw`, `_drop_data_fw` doesn't have `from_control` argument anymore
@coppolaemilio coppolaemilio merged commit 2d3f5e1 into dialogic-godot:main Jan 13, 2023
@coppolaemilio
Copy link
Collaborator

Thank you so much :)

coppolaemilio added a commit that referenced this pull request Jan 13, 2023
@coppolaemilio
Copy link
Collaborator

Sorry, I had to revert this changes, I thought I tested them before but I wasn't in the correct branch. With your changes I get these kind of errors:
res://addons/dialogic/Editor/Events/Fields/FilePicker.gd:34 - Invalid call to function 'set_drag_forwarding' in base 'LineEdit'. Expected 1 arguments

@vmedea
Copy link
Contributor Author

vmedea commented Jan 13, 2023

Oops, sorry! I wonder when that changed, the "latest" documentation does show the function with three arguments, didn't expect it to just change inbetween like that (I'm using godot master because I'm testing some things). Will try to check next time. In any case, you'll likely need the change at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants