Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual timeline loading speedups #1401

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Conversation

Jowan-Spooner
Copy link
Collaborator

@Jowan-Spooner Jowan-Spooner commented Jan 14, 2023

PR, that tries to speedup the loading of visual timelines.

While still far from optimal, this PR makes it so the body of events that have their body hidden by default is only build, once that body is opened.

Other changes:

  • removed left and right labels from event fields and add labels only when needed (to remove unnecessary nodes)
  • removed some not needed nodes from EventBlock scene
  • removed Popup window node from event block scene
  • played around with visual timeline style (sorry, couldn't help it)
  • added a lot of static typing hints
  • changed it so get_property_list is no longer used (new method name is get_event_editor_info) for storing the event editor fields, hopefully reducing the calls this method gets

ToDo:

  • reimplement popup window (this time only one node for all events)

Because the adding of nodes to the scene tree is the most intensive action during the loading this already speeds it up, especially for events with many body settings (like character, position and choice). More could possibly be removed by using draw commands (e.g. for icons) instead of nodes, especially on the Complex Picker (which is used in the condition picker for example).

Did a lot of playing around/testing. Needs a lot of cleanup following
@Jowan-Spooner Jowan-Spooner marked this pull request as ready for review January 14, 2023 09:31
@Jowan-Spooner
Copy link
Collaborator Author

Jowan-Spooner commented Jan 14, 2023

Would appreciate if someone with a "real" project could test this and let me know if the experience has improved for them, when opening long timelines.

@Jowan-Spooner Jowan-Spooner merged commit 8a31d92 into main Jan 19, 2023
@Jowan-Spooner Jowan-Spooner deleted the visual-timeline-speedups branch February 17, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant