Make text effects and modifiers modular #1403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the text effect and modifier logic from the DialogText node.
The index.gd file can now register text effects and modifiers.
These are effectively just methods. The text subsystem collects them and applies/reads them to/from the text before sending it to the DialogText node. Then the DialogText node calls execute_effects on every letter advance.
Text modifiers are also methods, these are only called once before the text is shown.
The text effect methods have access to the calling dialog_text node, the skipping boolean and the argument string.
All effects/modifiers have been moved to the text subsystem except portrait which is now part of the portrait subsystem.
Additionally the syntax for random selection has been changed from [option1, option2] to [option1/option2].
This PR improves little to nothing for the average user, but makes it easier