Layout editor #1421
Merged
Layout editor #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now autocreated by their subsystems. This removes a few possible features (which I'm sure can be worked around by professionals) but makes the creation of layout scenes easier (less required nodes).
This is the rest of the layout update. However many small other things have also come up, and I decided to push them into here. Sorry :(. # Layout update There is now a working layout editor. It has three modes "Preset", "Custom" and "No Scene". In Preset mode you can select one of the provided presets and customize it's exported variables. In Cutsom Mode you can select a scene from the file system. You can currently not customize it's exports yet. In No Scene mode, you can't set anything. The mode doesn't really do anything. The customization editor parses the exported variables similar to custom por trait scenes. This meant I moved some of it's functionality into the DialogicUtil, meaning the custom portraits exports also improved. Added DialogicUtil.get_default_layout() that returns the path to the default layout. Makes it easier to move in case needed. Removed layout scene settings from general settings page. Also changed the layout there a bit because of that. # Other things - Creating timelines/characters didn't add them into the sidebar instantly. Made some changes to the "latest_resource" list changing, to improve this - A wrong code prevented event block fields to be hidden when their condition was wrong. - Tried out a bit of a different color for the text event text field, but we could change it back if wanted. - removed print statements - fixed to_int() call to int() - fixed portrait position being referenced by global position to correclt place portraits - fixed a bug where Event.event_node_ready would prevent events from being played when created from code - Default to home page instead of timeline editor for first opening of plugin - fixed positioning of non canvas layer based scenes (e.g. Textbubble) - Added CTRL+F5 as shortcut for "Play current timeline"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly focused on the layout update. However many small other things have also come up, and I decided to push them into here. Sorry :(.
Layout update
There is now a working layout editor. It has three modes "Preset", "Custom" and "No Scene".
In Preset mode you can select one of the provided presets and customize it's exported variables.
In Cutsom Mode you can select a scene from the file system. You can currently not customize it's exports yet.
In No Scene mode, you can't set anything. The mode doesn't really do anything.
The customization editor parses the exported variables similar to custom por
trait scenes. This meant I moved some of it's functionality into the DialogicUtil, meaning the custom portraits exports also improved.
Added DialogicUtil.get_default_layout() that returns the path to the default layout. Makes it easier to move in case needed.
Removed layout scene settings from general settings page. Also changed the layout there a bit because of that.
Other things