Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Glossary Category #1492

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

mechPenSketch
Copy link
Contributor

This PR sets event_category in DialogicGlossaryEvent to Other because the previous value, AudioVisual, is not found in DialogicEvent.Category.

I originally presumed Other to be the category, but it could be Audio instead. Let me know the intended category, and I'll make a new PR branch.

@Jowan-Spooner
Copy link
Collaborator

Other is correct. I made this change too already for my local version but didn't push yet ;) Thanks!

@Jowan-Spooner Jowan-Spooner merged commit df7f942 into dialogic-godot:main Mar 30, 2023
@Jowan-Spooner
Copy link
Collaborator

The glossary event isn't even enabled right now, as it does nothing, so this really is just an annoyig error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants