Improve text systems and TextBubble layout system #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Text systems: - adds `about_to_show` signal to text subsystem. - adds enabled flag to text node # TextBubble Layout The text bubble layout will now display a different text bubble for each "registered" character and use a fallback one (that has no position tracking) for all other characters. Characters can be registered with the register_character() method that takes a dialogic character resource and a node2D to track to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text systems:
about_to_showsignal to text subsystem.TextBubble Layout
The text bubble layout will now display a different text bubble for each "registered" character and use a fallback one (that has no position tracking) for all other characters.
Characters can be registered with the register_character() method that takes a dialogic character resource and a node2D to track to.