Multiple fixes (all over the place) #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also adds autocompletion for the wait events hide_text setting
Not sure if it's a big improvement
# Choices
- you can now choose how/when choices are revealed. either
- instantly when the text finished (default, because previous behaviour)
- after a certain time (very useful if text speed is instant (0))
- after another input
- after an input OR a certain time
# Input
- The input handler now emits a dialogic_action signal that can be listend to
- The input handler reference in the Text subsystem is now named input_handler (previously input_handler_node)
# Textbox
The DialogText node now has three new settings: `enabled`, `hide_when_empty` and `textbox_root`.
- if enabled is false, this node will ignore calls to `reveal_text()` and the text subsystem will ignore the node
- if hide_when_empty() is true, the node will hide itself (without animation though) whenever set to an empty text
- textbox root determines what node should be hidden/revealed when the textbox shows/hides. It defaults to "self", but on the default layout it is set to the Panel containing the node.
- fixed a bug where text effects at the very end of a text event would be ignored
simple QOL improvement imo
|
Will merge this although it's messy. Hope nothing breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfortunate mess. I've been working on the example projects and making changes as needed along the way. This is the result of that.
Here is a list of the most prominent changes:
Choices
Input
Textbox
The DialogText node now has three new settings:
enabled,hide_when_emptyandtextbox_root.if enabled is false, this node will ignore calls to
reveal_text()and the text subsystem will ignore the nodeif hide_when_empty() is true, the node will hide itself (without animation though) whenever set to an empty text
textbox root determines what node should be hidden/revealed when the textbox shows/hides. It defaults to "self", but on the default layout it is set to the Panel containing the node.
fixed a bug where text effects at the very end of a text event would be ignored
Other