Fixed file picker in portrait scene exports #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The portrait export editor is unable to edit strings exported with the `@export_file` annotation because they weren't being correctly serialized with `var_to_str` before being stored in the tree item's metadata. The file picker is also ignoring submission events from its `LineEdit` child, which in this instance means the file picker's text box, despite being editable, can't actually be used to define the file. This commit fixes both issues. However, the fact that these were seemingly special-cased indicates to me that there may have been a conscious decision to make them this way. I was not able to determine what the reasoning might have been, so I leave the question open for reviewers.
oddfacade
commented
Jun 25, 2023
| flat = true | ||
|
|
||
| [connection signal="focus_entered" from="HBox/Field" to="." method="_on_field_focus_entered"] | ||
| [connection signal="focus_exited" from="HBox/Field" to="." method="_on_field_focus_exited"] | ||
| [connection signal="text_submitted" from="HBox/Field" to="." method="_on_file_dialog_selected"] |
There was a problem hiding this comment.
This is the actual change. I connected the text_submitted signal to the same callback used by the file selection dialog.
oddfacade
commented
Jun 25, 2023
| @@ -97,7 +95,7 @@ func _on_export_number_submitted(value:float, property_name:String) -> void: | |||
| set_export_override(property_name, var_to_str(value)) | |||
|
|
|||
| func _on_export_file_submitted(property_name:String, value:String) -> void: | |||
| set_export_override(property_name, value) | |||
| set_export_override(property_name, var_to_str(value)) | |||
There was a problem hiding this comment.
This is needed because it's read back and deserialized using str_to_var, which will give you null if it gets an unquoted string (that doesn't correspond to some other type).
|
Looks very good! Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portrait export editor is unable to edit strings exported with the
@export_fileannotation because they weren't being correctly serialized withvar_to_strbefore being stored in the tree item's metadata. The file picker is also ignoring submission events from itsLineEditchild, which in this instance means the file picker's text box, despite being editable, can't actually be used to define the file.This commit fixes both issues. However, the fact that these were seemingly special-cased indicates to me that there may have been a conscious decision to make them this way. I was not able to determine what the reasoning might have been, so I leave the question open for reviewers.